Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring, cleanup #130

Closed
wants to merge 1 commit into from
Closed

Conversation

kvaster
Copy link
Contributor

@kvaster kvaster commented Aug 5, 2023

  • Separate running controller and node servers
  • Allow to disable attacher - we do nothing on attach/detach to node it is really usefull
  • Refactoring of helm chart:
    • Add liveness probe
    • Allow leader election for controller sidecars (replicas count is configurable now)
  • Controller implements ControllerExpandVolume to only answer that node responsible for volume expansion
  • Controller should be Deployment insteadof StatefulSet
  • Driver support for gracefull shutdown
  • Use SIGTERM for weed mount gracefull shutdown - SIGHUP is not processed.
  • Cleanup staged volumes on shutdown
  • Use golang 1.20
  • Code refactoring & cleanup

Cleanup stage volumes on shutdown
Allow to disable useless csi-attacher
Code refactoring
Helm chart refactoring
@chrislusf
Copy link
Contributor

Nice PR and a lot of work! Thanks! Is it possible to break into separate PRs? Or have the commit history for each change?

@kvaster
Copy link
Contributor Author

kvaster commented Aug 6, 2023

I will try to split PR and keep commit history.

@kvaster kvaster marked this pull request as draft August 6, 2023 12:00
@kvaster
Copy link
Contributor Author

kvaster commented Aug 6, 2023

I will make changes via several PRs and with commit history - I think I will do it much better such way. I will close this PR as soon as all necessary changes (new PRs) will be reviewed and accepted.

@kvaster kvaster closed this Aug 7, 2023
@kvaster kvaster deleted the refactoring branch August 7, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants