Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load bundled gems on expected version #859

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Conversation

xjunior
Copy link
Contributor

@xjunior xjunior commented Jan 23, 2025

Fixes #789

psych is no longer a default gem, but current and old ruby still ships with it. When we require 'yaml', we activate that gem in whatever version that is bundled with ruby. Later on, we load bundler, and we Bundler.setup, which will then activate whatever version specified in the lock file. More often than not, they might not match.

The approach in this PR is to strip the yaml dependency completely from the hook scripts, while retaining the ability to configure the Gemfile using it.

@xjunior xjunior force-pushed the setup-bundled-gems branch from ad1355c to 79bd2ed Compare January 24, 2025 17:02
@wadewinningham
Copy link

I have this issue and it resolved it for me.

Copy link

@Victor-Oliveira Victor-Oliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have this same issue too. Those changes resolved it for me.

@sds sds added the bug label Jan 27, 2025
@sds sds merged commit 7d3e8fa into sds:main Jan 27, 2025
15 checks passed
@sds
Copy link
Owner

sds commented Jan 27, 2025

Thanks!

@sds
Copy link
Owner

sds commented Jan 27, 2025

Released in 0.65.0.

@xjunior xjunior deleted the setup-bundled-gems branch January 27, 2025 20:58
@xjunior xjunior restored the setup-bundled-gems branch January 27, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Psych & Ruby 3 incompatibility
4 participants