-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement(gemini): run gemini from scylladb/gemini #8953
improvement(gemini): run gemini from scylladb/gemini #8953
Conversation
I want to see a 10h run, with the statements logs, so we can see how bad is it (in size). |
I'm starting a new run right now, I'll reference it when it's started. |
from the 10h run (that lasted 12min)
|
Fixed with the last commit, now gemini looks like its stable for 43m, but after that same thing, fails on validation, and by the looks of the statement inside the select, generated statement is invalid by the schema, but that just continues. Issue 431 |
a0e0cff
to
7e38bab
Compare
22d8710
to
f20b322
Compare
this is waiting for fixes in gemini, to stabilize it, we can't use gemini in current state |
b2a8f41
to
733b25b
Compare
e6f5847
to
5f16c38
Compare
@CodeLieutenant |
e9f0f93
to
d338a7b
Compare
058d1a4
to
a643230
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 last pending issue
and also fix pre-commit autopep8 issues
@roydahan , @fruch , i tried the new Gemini but it seem to fail after warmup or something.
|
it died cause of OOM: it's a known issue, root cause still unknown |
precommit is failing on this:
|
ff5de8d
to
d17442e
Compare
d17442e
to
0822faa
Compare
Dockerfile has been moved to gemini project, and now SCT should use that image. Changes: - Use image from scylladb/gemini - Remove dockerfile for gemini and point in readme location for the images - Add CQL Statement Logging to gemini output - Forward outputs from docker to $HOME/*.log - Run default gemini flags from gemini_thread.py Signed-off-by: Dusan Malusev <[email protected]>
0822faa
to
30ddba1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Dockerfile has been moved to gemini project, and now SCT should use that image.
Changes:
Testing