Make driver print warnings returned by server #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/log-warnings-if-present
branch
2 times, most recently
from
e36b33f to
d0d3498
Compare
control.go
Outdated
Comment on lines
69
to
71
| session: session, | ||
| quit: make(chan struct{}), | ||
| retry: &SimpleRetryPolicy{NumRetries: 3}, |
There was a problem hiding this comment.
should be in separate commit, not related to the change
query_executor.go
Outdated
Comment on lines
21
to
30
| type ExecutableQuery interface { | ||
| ExecutableQueryInterface | ||
|
|
||
| borrowForExecution() // Used to ensure that the query stays alive for lifetime of a particular execution goroutine. | ||
| releaseAfterExecution() // Used when a goroutine finishes its execution attempts, either with ok result or an error. | ||
| execute(ctx context.Context, conn *Conn) *Iter | ||
| attempt(keyspace string, end, start time.Time, iter *Iter, host *HostInfo) | ||
| retryPolicy() RetryPolicy | ||
| speculativeExecutionPolicy() SpeculativeExecutionPolicy | ||
| withContext(context.Context) ExecutableQuery | ||
| } | ||
|
|
There was a problem hiding this comment.
why this split to ExecutableQueryInterface and ExacutableQuery?
There was a problem hiding this comment.
reverted this back, I wanted to make ExecutableQuery interface implementable
dkropachev
force-pushed
the
dk/log-warnings-if-present
branch
from
d0d3498 to
cae9b90
Compare
dkropachev
force-pushed
the
dk/log-warnings-if-present
branch
from
cae9b90 to
f496ba2
Compare
|
@sylwiaszunejko , please take a look again |
sylwiaszunejko
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time to time server provides usefull information in warnings.
Almost all drivers print it out, we need to make gocql do the same.