Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scylla): failed to start scylla due to fs.aio limit #447

Merged
merged 3 commits into from
Dec 23, 2024
Merged

fix(scylla): failed to start scylla due to fs.aio limit #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62f177f
fix(integration-tests): increase fs.aio-max-nr and fs.file-max
CodeLieutenant Dec 12, 2024
43fede8
fix(integration-tests): run integration tests in parallel
CodeLieutenant Dec 12, 2024
1157b2c
improvement(github-actions): run always on ubuntu 24.04
CodeLieutenant Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ on:

jobs:
goreleaser:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dockerhub-description.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
- .github/workflows/dockerhub-description.yml
jobs:
description:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
jobs:
build:
name: Lint Test and Build
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name:
uses: actions/checkout@v4
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
build:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name:
uses: actions/checkout@v4
Expand All @@ -31,9 +31,9 @@ jobs:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
needs: [build]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
strategy:
max-parallel: 1
max-parallel: 4
matrix:
gemini-features: ["basic", "normal"]
gemini-concurrency: [4]
Expand All @@ -49,6 +49,10 @@ jobs:
id: scylla
shell: bash
run: |
ulimit -n 65536
sudo sysctl -w fs.aio-max-nr=30000000
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about https://opensource.docs.scylladb.com/stable/kb/scylla-limits-systemd.html#before-you-start ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is done for holding fs to lot's of sstables, our tests are not suppose to generate lot's of them.

sudo sysctl -w fs.file-max=30000000

chmod +x ./bin/gemini
make scylla-setup \
SCYLLA_TEST_VERSION=${{ matrix.test-scylla-version }} \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ permissions:

jobs:
goreleaser:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
4 changes: 4 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,10 @@ setup: $(GOBIN)/golangci-lint scylla-setup debug-build
scylla-setup:
@docker compose -f docker/docker-compose-$(DOCKER_COMPOSE_TESTING).yml up -d

until docker logs gemini-oracle 2>&1 | grep "Starting listening for CQL clients" > /dev/null; do sleep 0.2; done
until docker logs gemini-test 2>&1 | grep "Starting listening for CQL clients" > /dev/null; do sleep 0.2; done


.PHONY: scylla-shutdown
scylla-shutdown:
@docker compose -f docker/docker-compose-$(DOCKER_COMPOSE_TESTING).yml down --volumes
Expand Down
Loading