Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lints): all gemini lint warning fixes -> as per current golangci rules #439

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix(lints): all gemini lint warning fixes -> as per current golangci rules #439

merged 1 commit into from
Nov 29, 2024

Conversation

CodeLieutenant
Copy link
Contributor

@CodeLieutenant CodeLieutenant commented Nov 28, 2024 •
edited
Loading

  1. Update GolangCI configration for validate all files when run in GH Action
  2. Fix files to be correct according to the .golangci rules

@CodeLieutenant CodeLieutenant added enhancement New feature or request good first issue Good for newcomers github_actions Pull requests that update GitHub Actions code labels Nov 28, 2024
@CodeLieutenant CodeLieutenant self-assigned this Nov 28, 2024
@CodeLieutenant CodeLieutenant changed the title fix(lints): all gemini lint warning fixes -> as per current golangci … fix(lints): all gemini lint warning fixes -> as per current golangci rules Nov 28, 2024
@CodeLieutenant CodeLieutenant added this to the Gemini 1.9 milestone Nov 28, 2024
@dkropachev dkropachev merged commit 88aaa06 into scylladb:master Nov 29, 2024
3 of 4 checks passed
@CodeLieutenant CodeLieutenant deleted the fix/linting branch December 23, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkropachev dkropachev dkropachev approved these changes

Assignees

@CodeLieutenant CodeLieutenant

Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers
Projects
None yet
Milestone
Gemini 1.9
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeLieutenant @dkropachev