refactor(generator): generators use context.Context instead of stopflag #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeLieutenant
force-pushed
the
refactor/generators-to-context
branch
from
cf35363 to
e3aae54
Compare
In process of removing the `stopFlag` from gemini's codebase, first step is to migrate the `Value Generators` for patitions. Using context with generators make a lot more sense then the custom built, `stopFlag`. `context` is built-in package in Go, and this is it's usecase - cancelation propagation to background task. Signed-off-by: Dusan Malusev <[email protected]>
CodeLieutenant
force-pushed
the
refactor/generators-to-context
branch
2 times, most recently
from
fdff5c2 to
10e784b
Compare
Signed-off-by: Dusan Malusev <[email protected]>
CodeLieutenant
force-pushed
the
refactor/generators-to-context
branch
from
10e784b to
f2f6a23
Compare
|
start with describing the problem this PR is solving, and why do we need this change |
I'll do that in an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In process of removing the
stopFlagfrom gemini's codebase, first step is to migrate theValue Generatorsfor patitions. Using context with generators make a lot more sense then the custom built,stopFlag.contextis built-in package in Go, and this is it's usecase - cancelation propagation to background task.