feature(materialized-views): add cli flags to disable materialized views #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a crash in gemini, which is deeped then we expected first, and it comes down to the materialized views generation and validation. Something there is wrong, until further investigation (and possibly gemini redisign, this issue cannot be fixed). As I've discussed with @fruch about this issue, we concluded that the best way forward for now is to disable materialized views until the redisign of the project. Simplest solution is just to add the CLI flag and propagate it to the creation of the materialized views. Signed-off-by: Dusan Malusev <[email protected]>
dkropachev
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a crash in gemini, which is deeped then we expected first, and it comes down to the materialized views generation and validation. Something there is wrong, until further investigation (and possibly gemini redisign, this issue cannot be fixed). As I've discussed with @fruch about this issue, we concluded that the best way forward for now is to disable materialized views until the redisign of the project.
Simplest solution is just to add the CLI flag and propagate it to the creation of the materialized views.
Jenkins Issue: https://jenkins.scylladb.com/job/enterprise-2024.1/job/gemini-/job/gemini-3h-with-nemesis-test/27/