-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo columnDef.UnmarshalJSON #360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are touching naming let's name value and key types properly in all complex types, i.e. ValueTypes, KeyTypes accordingly.
*redid columns 'UnmarshalJSON'
19b3fb0
to
4679e78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make a test to marshal
/unmarshal
cmd/gemini/schema.json
*added function that`s adding referenses in 'IndexDef' on 'ColumnDef' for loaded schema from file *some fixes
issue #353.
Added 'complex_type' for all complex types of columns.
Redid columns 'UnmarshalJSON'.
Now complex type column description in JSON looks like it:
Before can`t see complex type that is describe: