Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chain_qc adaptation (isotypically included B cells) #537

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Chain_qc adaptation (isotypically included B cells) #537

merged 4 commits into from
Aug 13, 2024

Conversation

MKanetscheider
Copy link
Collaborator

@MKanetscheider MKanetscheider commented Aug 9, 2024 •
edited by grst
Loading

Closes #...
Enable labeling of isotypically included B cells as receptor_subtype

  • CHANGELOG.md updated
  • Tests added (For bug fixes or new features)
  • Tutorial updated (if necessary)

@grst
Copy link
Collaborator

grst commented Aug 11, 2024

Happy to include this!
The corresponding test case is here, should be relatively easy to adapt:

scirpy/src/scirpy/tests/test_tools.py

Line 19 in 6160f37

def test_chain_qc():

All the existing tests should pass and there should be at least one case of an isotypicall included B cell tested.

grst
grst approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just updated the Changelog

@grst grst merged commit e139ba3 into scverse:main Aug 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grst grst grst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MKanetscheider @grst