Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JANITORIAL: Fix typos in tools #78

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
f953c27
JANITORIAL: Fix availiable typo in p12explore.py
raziel- Sep 7, 2024
b83c2a5
JANITORIAL: Fix compability typo in scummsys.h
raziel- Sep 7, 2024
d939372
JANITORIAL: Fix continous typo in main.cpp
raziel- Sep 7, 2024
9856813
JANITORIAL: Fix convertion typo in convert_dxa.bat
raziel- Sep 7, 2024
82bcea2
JANITORIAL: Fix excercise typo in util.h
raziel- Sep 7, 2024
6c67523
JANITORIAL: Fix between typo in compress_sci.cpp
raziel- Sep 7, 2024
ae578f0
JANITORIAL: Fix infomation typo in pack_prince.cpp
raziel- Sep 7, 2024
4e08caf
JANITORIAL: Fix interchangably typo in overview.tex
raziel- Sep 7, 2024
3eb4c58
JANITORIAL: Fix lenght typos in patchex.cpp
raziel- Sep 7, 2024
0eb0ef6
JANITORIAL: Fix lenght typos in ResidualVM-Patch.txt
raziel- Sep 7, 2024
ab0a0f7
JANITORIAL: Fix managment typo in str.h
raziel- Sep 7, 2024
f7e8f0b
JANITORIAL: Fix occurence typo in todo.tex
raziel- Sep 7, 2024
e3a7c8f
JANITORIAL: Fix proces typo in version.cpp
raziel- Sep 7, 2024
93b0eca
JANITORIAL: Fix refered typo in scummvm-tools.nsi
raziel- Sep 7, 2024
6dec451
JANITORIAL: Fix refered typo in scummvm-tools.nsi.in
raziel- Sep 7, 2024
6148bc5
JANITORIAL: Fix refered typo in engine.py
raziel- Sep 7, 2024
65f3e27
JANITORIAL: Fix refering typo in ptr.h
raziel- Sep 7, 2024
19bf3a8
JANITORIAL: Fix seeked typo in stream.cpp
raziel- Sep 7, 2024
081b966
JANITORIAL: Fix seperating typo in main.h
raziel- Sep 7, 2024
75e9d43
JANITORIAL: Fix substract typo in create_sjisfnt.cpp
raziel- Sep 7, 2024
3394f1f
JANITORIAL: Fix unkown typos in qtvr.hexpat
raziel- Sep 7, 2024
47b3db2
JANITORIAL: Fix dosen't typo in lmem.cpp
raziel- Sep 7, 2024
b38bd74
JANITORIAL: Fix thats typo in compress_sci.cpp
raziel- Sep 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/ptr.h
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ class SharedPtr : public SafeBool<SharedPtr<T> > {
}

/**
* Checks if the object is the only object refering
* Checks if the object is the only object referring
* to the assigned pointer. This should just be used for
* debugging purposes.
*/
Expand Down
2 changes: 1 addition & 1 deletion common/scummsys.h
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@
// This is done for two reasons
// a) uint is already defined by Symbians libc component
// b) Symbian is using its "own" datatyping, and the Scummvm port
// should follow this to ensure the best compability possible.
// should follow this to ensure the best compatibility possible.
#define SCUMMVM_DONT_DEFINE_TYPES
typedef unsigned char byte;

Expand Down
2 changes: 1 addition & 1 deletion common/str.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
namespace Common {

/**
* Simple string class for ScummVM. Provides automatic storage managment,
* Simple string class for ScummVM. Provides automatic storage management,
* and overloads several operators in a 'natural' fashion, mimicking
* the std::string class. Even provides simple iterators.
*
Expand Down
2 changes: 1 addition & 1 deletion common/stream.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ bool BufferedSeekableReadStream::seek(int64 offset, int whence) {
if (whence == SEEK_CUR)
offset -= (_bufSize - _pos);
// We invalidate the buffer here. This assures that successive seeks
// do not have the chance to incorrectly think they seeked back into
// do not have the chance to incorrectly think they seek'd back into
// the buffer.
// Note: This does not take full advantage of the buffer. But it is
// a simple way to prevent nasty errors. It would be possible to take
Expand Down
2 changes: 1 addition & 1 deletion convert_dxa.bat
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ goto :eof
:check_bink
if exist "%BINK_PATH%\binkconv.exe" goto :preencode
echo.
echo Bink convertion tool cannot be found!
echo Bink conversion tool cannot be found!
goto :eof

:preencode
Expand Down
2 changes: 1 addition & 1 deletion create_sjisfnt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ void Glyph::convertChar16x16(uint8 *dst) const {
}

void fixYOffset(GlyphList &glyphs) {
// We try to find the minimum y offset here so we can substract it to make it 0 in the end.
// We try to find the minimum y offset here so we can subtract it to make it 0 in the end.
// We need to do this, since otherwise the characters will take up too much vertical space.
int minYOffset = 0xFFFF;

Expand Down
2 changes: 1 addition & 1 deletion decompiler/doc/overview.tex
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ \subsection{Reading guide}
\end{lstlisting}
\end{C++}

In this document, the terms \emph{control flow analysis} and \emph{code flow analysis} are used interchangably.
In this document, the terms \emph{control flow analysis} and \emph{code flow analysis} are used interchangeably.

\subsection{Limitations}
The decompiler is targeted for stack-based instruction sets, and may contain assumptions to that effect. If you want to add an engine which does not use a stack-based instruction set, parts of this document may not apply directly, and additional work to the generic parts may be necessary.
2 changes: 1 addition & 1 deletion decompiler/doc/todo.tex
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ \subsection{Allow conditional jumps to be used for break/continue}

Support for this should be added to the analysis. Should be doable by also checking destinations of unmarked conditional jumps, since ifs are marked after breaks and continues - so simply add that to the initial filter and make sure we process the right (non-sequential) target vertex.

Classifying as an enhancement since it appears this optimization is not used in SCUMMv6 (there is an if (...) break in tentacle/room-13-206, but the break is a separate jump). Not sure if KYRA uses it - a cursory scan of the KYRA2 demo suggests that it could use an optimization, as I found only 1 occurence of a c1\_ifNotJmp immediately followed by a c1\_jump (skull\textbackslash skull.emc, 0x0578) - but it did not look like a loop. That, however, does not prove that KYRA actually uses the optimization - it could simply be that such a piece of code was never used.
Classifying as an enhancement since it appears this optimization is not used in SCUMMv6 (there is an if (...) break in tentacle/room-13-206, but the break is a separate jump). Not sure if KYRA uses it - a cursory scan of the KYRA2 demo suggests that it could use an optimization, as I found only 1 occurrence of a c1\_ifNotJmp immediately followed by a c1\_jump (skull\textbackslash skull.emc, 0x0578) - but it did not look like a loop. That, however, does not prove that KYRA actually uses the optimization - it could simply be that such a piece of code was never used.

As far as I have been able to tell, this optimization really is not used in Kyra, so this will have to be deferred until we have an engine which needs it.

Expand Down
4 changes: 2 additions & 2 deletions dists/win32/scummvm-tools.nsi
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,15 @@ Name "ScummVM Tools"
!define COMPANY "ScummVM Team"
!define URL "https://www.scummvm.org/"
!define DESCRIPTION "ScummVM Tools Installer. Look! A three headed monkey (TM)!"
!define COPYRIGHT "Copyright © 2001-2023 The ScummVM Team"
!define COPYRIGHT "Copyright © 2001-2023 The ScummVM Team"

#########################################################################################
# Installer configuration
#########################################################################################
OutFile ${build_dir}\scummvm-tools-${VERSION}-${ARCH}.exe
InstallDir $PROGRAMFILES\ScummVM\tools ; Default installation folder
InstallDirRegKey HKCU "Software\ScummVM\ScummVM Tools" "InstallPath" ; Get installation folder from registry if available
; The application name needs to be refered directly instead of through ${REGKEY}
; The application name needs to be referred to directly instead of through ${REGKEY}
; because lang strings aren't initialized at the point InstallDirRegKey is called

CRCCheck on
Expand Down
4 changes: 2 additions & 2 deletions dists/win32/scummvm-tools.nsi.in
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,15 @@ Name "ScummVM Tools"
!define COMPANY "ScummVM Team"
!define URL "https://www.scummvm.org/"
!define DESCRIPTION "ScummVM Tools Installer. Look! A three headed monkey (TM)!"
!define COPYRIGHT "Copyright © 2001-2023 The ScummVM Team"
!define COPYRIGHT "Copyright © 2001-2023 The ScummVM Team"

#########################################################################################
# Installer configuration
#########################################################################################
OutFile ${build_dir}\scummvm-tools-${VERSION}-${ARCH}.exe
InstallDir $PROGRAMFILES\ScummVM\tools ; Default installation folder
InstallDirRegKey HKCU "Software\ScummVM\ScummVM Tools" "InstallPath" ; Get installation folder from registry if available
; The application name needs to be refered directly instead of through ${REGKEY}
; The application name needs to be referred to directly instead of through ${REGKEY}
; because lang strings aren't initialized at the point InstallDirRegKey is called

CRCCheck on
Expand Down
4 changes: 2 additions & 2 deletions engines/director/patterns/qtvr.hexpat
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ struct UnknownAtomSelector {
Atom atom_header [[hidden]];
$ = addressof(this);
UnknownAtom unknown [[name(atom_header.box_type)]];
std::print("unkown: " + atom_header.box_type);
std::print("unknown: " + atom_header.box_type);
} [[inline]];

struct UnknownAtom : Atom {
Expand All @@ -160,7 +160,7 @@ struct UnknownAtom : Atom {
} else {
$ = next_offset;
}
std::print("unkown atom: {}: {}", box_type, $);
std::print("unknown atom: {}: {}", box_type, $);
} [[format("format_box_type")]];

fn format_box_type(auto box) {
Expand Down
4 changes: 2 additions & 2 deletions engines/grim/docs/ResidualVM-Patch.txt
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ Offset Size Var
6 2 VersionMinor <= 0
8 4 flags
12 16 md5sum of old file
28 4 lenght of old file
32 4 lenght of new file
28 4 length of old file
32 4 length of new file
36 4 length of gzipped ctrl block (x)
40 4 length of gzipped diff block (y)
44 4 length of gzipped extra block (z) (if zero the extra block is missing or mixed with diff block)
Expand Down
2 changes: 1 addition & 1 deletion engines/grim/lua/lmem.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ void *luaM_realloc (void *block, int32 size)
int32 realsize = HEADER+size+1;
if (realsize != (size_t)realsize)
lua_error("Allocation Error: Block too big");
if (size == 0) { /* ANSI dosen't need this, but some machines... */
if (size == 0) { /* ANSI doesn't need this, but some machines... */
if (block) {
int32 *b = (int32 *)((char *)block - HEADER);
memset(block, -1, *b); /* erase block */
Expand Down
6 changes: 3 additions & 3 deletions engines/grim/patchex/patchex.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ static struct mspack_system res_system = {
&res_tell, NULL
};

void extract_cabinet(char *filename, unsigned int lenght) {
void extract_cabinet(char *filename, unsigned int length) {
struct mspack_file *original_executable, *destination_cabinet;
void *buffer;
unsigned int copied_bytes, remBytes;
Expand All @@ -224,8 +224,8 @@ void extract_cabinet(char *filename, unsigned int lenght) {
buffer = malloc(BUFFER_SIZE);
copied_bytes = 0;

while (copied_bytes < lenght) {
remBytes = lenght - copied_bytes;
while (copied_bytes < length) {
remBytes = length - copied_bytes;
count = res_read(original_executable, buffer, (remBytes < BUFFER_SIZE) ? remBytes : BUFFER_SIZE);
writeResult = res_write(destination_cabinet, buffer, count);
copied_bytes += count;
Expand Down
2 changes: 1 addition & 1 deletion engines/petka/p12explore.py
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ def path_res_open(self, pref, res_id, mode):
format(flc.width, flc.height, \
flc.frame_num, flc.delay))
else:
self.add_info("No information availiable")
self.add_info("No information available")
except:
self.add_info("Error loading {} - \"{}\" \n\n{}".\
format(res_id, hlesc(fn), hlesc(traceback.format_exc())))
Expand Down
4 changes: 2 additions & 2 deletions engines/petka/petka/engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -588,8 +588,8 @@ def load_dialogs(self, fixname = None, lodname = None, noobjref = False):
act.num_dlgs = num_dlgs
if not noobjref:
if ref not in self.obj_idx:
raise EngineError("Dialog group 0x{:x} refered "\
"to unexisted object 0x{:x}".format(
raise EngineError("Dialog group 0x{:x} referred "\
"to unexisting object 0x{:x}".format(
grp.idx, ref))
act.obj = self.obj_idx[act.ref]
grp.acts.append(act)
Expand Down
2 changes: 1 addition & 1 deletion engines/prince/pack_prince.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ void PackPrince::execute() {
_fFiles.print("credits_translate.dat\n");


// Export files infomation
// Export files information
int posOfFilesInformation = _fFiles.pos();
FileEntry filesInfo[5];
int fileNr = 0;
Expand Down
2 changes: 1 addition & 1 deletion engines/sci/attic/util.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

#include "common/scummsys.h"

/* An excercise in bloated macro writing ;-)*/
/* An exercise in bloated macro writing ;-)*/

/*Declare a flexarray type*/
#define FLEXARRAY(type, extra) struct{\
Expand Down
4 changes: 2 additions & 2 deletions engines/sci/compress_sci.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ SciResourceDataType CompressSci::detectData(byte *header, bool compressMode) {
}
byte buffer[20];
memcpy(&buffer, header, 6);
// Fixup for pharkas resource.sfx, several WAVE files contain a size thats not right (-1 byte)
// Fixup for pharkas resource.sfx, several WAVE files contain a size that's not right (-1 byte)
int offset = 0;
if (memcmp(buffer + 1, "RIFF", 4) == 0) {
offset = 5;
Expand All @@ -98,7 +98,7 @@ SciResourceDataType CompressSci::detectData(byte *header, bool compressMode) {
if (memcmp(buffer, "\x8d\x0bSOL\x00", 6) == 0) {
// SOL files begin with
// 0x8D 0x0B/0x0C "SOL" 0x00 [samplerate:WORD] [flags:BYTE] [size of following data after header:DWORD]
// 0x0C variant have an additional byte inbetween data and [size of]
// 0x0C variant have an additional byte between data and [size of]
_input.read_throwsOnError(&buffer[6], 7);
dataSize = READ_LE_UINT32(buffer + 9);
_inputEndOffset = _inputOffset + 13 + dataSize;
Expand Down
2 changes: 1 addition & 1 deletion gui/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ void ScummToolsFrame::onIdle(wxIdleEvent &evt) {
if (_pages.back()->onIdle(dynamic_cast<wxPanel *>(_wizardpane->FindWindow(wxT("Wizard Page"))))) {
// We want more!
evt.RequestMore(true);
// This way we don't freeze the OS with continous events
// This way we don't freeze the OS with continuous events
wxMilliSleep(10);
}
}
Expand Down
2 changes: 1 addition & 1 deletion gui/main.h
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ class WizardButtons : public wxPanel {
wxButton *_prefs;
/** 'Cancel' button. */
wxButton *_cancel;
/** The static text on the line seperating the page area and the buttons. */
/** The static text on the line separating the page area and the buttons. */
wxStaticText *_linetext;
/** Current page, required for dumping events to it. */
WizardPage *_currentPage;
Expand Down
2 changes: 1 addition & 1 deletion version.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
* header file, analog to internal_version.h, maybe called svn_rev.h or so.)
*
* Drawback: This only works on systems which can run suitable scripts as part
* of the build proces (so I guess Visual C++ would be out of the game here?
* of the build process (so I guess Visual C++ would be out of the game here?
* I don't know VC enough to be sure). And of course it must be robust enough
* to properly work in exports (i.e. release tar balls etc.).
*/
Expand Down
Loading