forked from privacy-scaling-explorations/zkevm-circuits
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Optimize zktrieState with flatten proofs #1388
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
github-actions
bot
added
crate-bus-mapping
crate-integration-tests
crate-eth-types
labels
Aug 4, 2024
lispc
reviewed
Aug 7, 2024
use key cache
Has passed >300 blocks on l2 mainnet with |
Passed another bulk of blocks with chunk builder in (Also with a tirival fixing on |
Test for compatibility of old trace has passed. A regression has completed with the newest commit. |
lispc
pushed a commit
that referenced
this pull request
Aug 13, 2024
* induce "query" mode for building sdb Signed-off-by: noelwei <[email protected]> * switch zktrie dep Signed-off-by: noelwei <[email protected]> * induce flatten proof and integration test Signed-off-by: noelwei <[email protected]> * update zk_dep use key cache * fix test issue * update zktrie dep * induce mpt state updating * fix issue in chunk building --------- Signed-off-by: noelwei <[email protected]>
lispc
added a commit
that referenced
this pull request
Aug 14, 2024
…hanges (#1392) * [Feat] Optimize zktrieState with flatten proofs (#1388) * induce "query" mode for building sdb Signed-off-by: noelwei <[email protected]> * switch zktrie dep Signed-off-by: noelwei <[email protected]> * induce flatten proof and integration test Signed-off-by: noelwei <[email protected]> * update zk_dep use key cache * fix test issue * update zktrie dep * induce mpt state updating * fix issue in chunk building --------- Signed-off-by: noelwei <[email protected]> * update zktrie * use v0.8 for zktrie * use v0.9 for zktrie * update cargo lock --------- Signed-off-by: noelwei <[email protected]> Co-authored-by: Ho <[email protected]>
lispc
added a commit
that referenced
this pull request
Sep 5, 2024
…hanges (#1392) * [Feat] Optimize zktrieState with flatten proofs (#1388) * induce "query" mode for building sdb Signed-off-by: noelwei <[email protected]> * switch zktrie dep Signed-off-by: noelwei <[email protected]> * induce flatten proof and integration test Signed-off-by: noelwei <[email protected]> * update zk_dep use key cache * fix test issue * update zktrie dep * induce mpt state updating * fix issue in chunk building --------- Signed-off-by: noelwei <[email protected]> * update zktrie * use v0.8 for zktrie * use v0.9 for zktrie * update cargo lock --------- Signed-off-by: noelwei <[email protected]> Co-authored-by: Ho <[email protected]>
lispc
added a commit
that referenced
this pull request
Sep 10, 2024
…hanges (#1392) * [Feat] Optimize zktrieState with flatten proofs (#1388) * induce "query" mode for building sdb Signed-off-by: noelwei <[email protected]> * switch zktrie dep Signed-off-by: noelwei <[email protected]> * induce flatten proof and integration test Signed-off-by: noelwei <[email protected]> * update zk_dep use key cache * fix test issue * update zktrie dep * induce mpt state updating * fix issue in chunk building --------- Signed-off-by: noelwei <[email protected]> * update zktrie * use v0.8 for zktrie * use v0.9 for zktrie * update cargo lock --------- Signed-off-by: noelwei <[email protected]> Co-authored-by: Ho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make use of the new "flatten proof" in
l2trace
to optimize the construction of zktrie state.With flatten proof and key hashes, no poseidon calculation would be required in constructing the initial zktrie state.
DO NOT MERGE unti following tasks are completedzktrie
has been merged taggedl2trace
usage oftxStorageTrace
has been proven to be correct