-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #1042 Allow configure db ConnMaxLifetime & ConnMaxIdleTime #1198
Conversation
55fe165
to
8a21fe4
Compare
looks great. do you think we can
|
@HAOYUatHZ Done. |
@HAOYUatHZ I have fixed the failing test cases. |
looks weird that there are so many contracts diff I guess it's because the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1198 +/- ##
===========================================
- Coverage 56.79% 56.39% -0.41%
===========================================
Files 155 157 +2
Lines 11848 11966 +118
===========================================
+ Hits 6729 6748 +19
- Misses 4613 4712 +99
Partials 506 506
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@HAOYUatHZ The additional file change happened after I rebased to develop. I am closing this PR in favour of #1207. It has all the changes |
Purpose or design rationale of this PR
Allow
connMaxLifetime
andconnMaxIdleTime
to be configured for database connectionsfeat: #1042 Allow configure db ConnMaxLifetime & ConnMaxIdleTime
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?