feat: mpt migration related changes #73
Open
+893
−1,602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfirmak
reviewed
Jan 20, 2025
omerfirmak
reviewed
Jan 20, 2025
omerfirmak
reviewed
Jan 20, 2025
omerfirmak
reviewed
Jan 20, 2025
Thegaram
reviewed
Jan 20, 2025
omerfirmak
reviewed
Jan 21, 2025
omerfirmak
reviewed
Jan 22, 2025
Thegaram
reviewed
Jan 23, 2025
Thegaram
reviewed
Jan 23, 2025
|
|
||
| // solhint-disable no-inline-assembly | ||
|
|
||
| contract ZkEvmVerifierPostEuclid is IZkEvmVerifierV2 { |
There was a problem hiding this comment.
Please ask the relevant person from the zk team to review this.
Thegaram
approved these changes
Jan 24, 2025
| // Make sure we don't finalize v4, v5 and v6 batches in the same bundle, that | ||
| // means `batchIndex < euclidForkBatchIndex` or `prevBatchIndex >= euclidForkBatchIndex`. | ||
| if (prevBatchIndex < euclidForkBatchIndex && euclidForkBatchIndex <= batchIndex) { | ||
| revert ErrorFinalizePreAndPostEuclidBatchInOneBundle(); |
There was a problem hiding this comment.
Well if we try to do this the proof verification should never pass. But we can keep this as a sanity check if you prefer.
Comment on lines
+111
to
+121
| /// @dev Thrown when SC finalize V5 batch before all v4 batches are finalized. | ||
| error ErrorNotAllV4BatchFinalized(); | ||
|
|
||
| /// @dev Thrown when the committed v5 batch doesn't contain only one chunk. | ||
| error ErrorV5BatchNotContainsOnlyOneChunk(); | ||
|
|
||
| /// @dev Thrown when the committed v5 batch doesn't contain only one block. | ||
| error ErrorV5BatchNotContainsOnlyOneBlock(); | ||
|
|
||
| /// @dev Thrown when the committed v5 batch contains some transactions (L1 or L2). | ||
| error ErrorV5BatchContainsTransactions(); |
There was a problem hiding this comment.
Seems a bit overkill, we could just use one error ErrorInvalidV5Batch.
Comment on lines
-538
to
+378
| bytes calldata _batchHeader, | ||
| bytes32 _postStateRoot, | ||
| bytes32 _withdrawRoot, | ||
| bytes calldata _aggrProof | ||
| bytes calldata batchHeader, | ||
| bytes32 postStateRoot, | ||
| bytes32 withdrawRoot, | ||
| bytes calldata aggrProof |
There was a problem hiding this comment.
Just curious, why did you change this? Previously you consistently preferred underscore for function arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.