feat: enforced messages and enforces messages #61
Conversation
| L2BaseFeeParameters memory parameters = l2BaseFeeParameters; | ||
| // this is unlikely to happen, use unchecked here | ||
| unchecked { | ||
| return (block.basefee * parameters.scalar) / PRECISION + parameters.overhead; |
There was a problem hiding this comment.
we may set a backlog task to decommission part of the gas-oracle as a reminder, removing "updating l2 base fee in l1 contract".
after this new contract is deployed, although there shouldn't be any problems if we don't remove the code, just keeps printing "fee estimation failed, execution reverted" when simulating the txn.
| /// @param postStateRoot The state root of current batch. | ||
| /// @param withdrawRoot The withdraw trie root of current batch. | ||
| /// @param version The version of current batch. | ||
| /// @param parentBatchHeader The header of parent batch, see the comments of `BatchHeaderV0Codec`. |
There was a problem hiding this comment.
| /// @param parentBatchHeader The header of parent batch, see the comments of `BatchHeaderV0Codec`. | |
| /// @param parentBatchHeader The header of parent batch, see the comments of `BatchHeaderV0Codec`, `BatchHeaderV1Codec` and `BatchHeaderV3Codec.sol`. |
|
|
||
| /// @param The struct for batch committing. | ||
| /// @param version The version of current batch. | ||
| /// @param parentBatchHeader The header of parent batch, see the comments of `BatchHeaderV0Codec`. |
There was a problem hiding this comment.
| /// @param parentBatchHeader The header of parent batch, see the comments of `BatchHeaderV0Codec`. | |
| /// @param parentBatchHeader The header of parent batch, see the comments of `BatchHeaderV0Codec`, `BatchHeaderV1Codec` and `BatchHeaderV3Codec.sol`. |
| /// timestamp `[t+maxFinalizeDelay, t+maxDelayEnterEnforcedMode]`. | ||
| struct EnforcedBatchParameters { | ||
| uint64 maxInclusionDelay; | ||
| uint64 maxFinalizeDelay; |
There was a problem hiding this comment.
how to resolve the issue when prover cannot finalize any batches before maxFinalizeDelay? Since finalizeBundleWithProof and finalizeBundleWithTeeProof are blocked by:
_checkFinalizationAllowed(enforcedBatchParameters.maxFinalizeDelay);
| batchPtr := mload(0x40) | ||
| _totalL1MessagesPoppedOverall := add(_totalL1MessagesPoppedOverall, _totalL1MessagesPoppedInBatch) | ||
| /// @inheritdoc IScrollChain | ||
| function commitBatchWithBlobProof( |
There was a problem hiding this comment.
Is this interface used for rollup-relayer upgrading commit interface asynchronously?
src/L1/rollup/ScrollChain.sol
Outdated
| /// @inheritdoc IScrollChain | ||
| function commitAndFinalizeBatch(CommitStruct calldata commitStruct, FinalizeStruct calldata finalizeStruct) | ||
| external | ||
| whenFinalizeNotPaused |
There was a problem hiding this comment.
this interface checks whenFinalizeNotPaused, iiuc it will be paused when security council is resolving zk and tee proof divergence, not sure if it will break some conditions of "permissionless exit" in stage 1. e.g. unresolvedState has never been cleared, then commitAndFinalizeBatch cannot be triggered forever.
| /// @param overhead The address of new whitelist checker contract. | ||
| /// @param scalar The address of new whitelist checker contract. |
| /// @return _parentBatchHash The batch hash of parent batch header. | ||
| /// @return _batchIndex The index of current batch. | ||
| /// @return _totalL1MessagesPoppedOverall The total number of L1 messages popped before current batch. | ||
| function _beforeCommitBatch(bytes calldata _parentBatchHeader, bytes[] memory _chunks) | ||
| function _beforeCommitBatch( |
There was a problem hiding this comment.
There's only 1 call site for _beforeCommitBatch in line 567 and we always call it with lastCommittedBatchIndex=0. Why is that?
(bytes32 _parentBatchHash, uint256 _batchIndex, uint256 _totalL1MessagesPoppedOverall) = _beforeCommitBatch(
_parentBatchHeader,
_chunks,
0
);
There was a problem hiding this comment.
fixed, one of the left todo.
src/L1/rollup/ScrollChain.sol
Outdated
| ); | ||
| BatchHeaderV0Codec.storeBatchIndex(batchPtr, _batchIndex); | ||
|
|
||
| // versions 2 and 3 both use ChunkCodecV1 | ||
| (bytes32 _dataHash, uint256 _totalL1MessagesPoppedInBatch) = _commitChunksV1( | ||
| _totalL1MessagesPoppedOverall, | ||
| _chunks, | ||
| _skippedL1MessageBitmap | ||
| 0 // parameters.maxInclusionDelay |
There was a problem hiding this comment.
is this a TODO?
since we also call _commitBatchWithBlobProof from commitAndFinalizeBatch we apply the same logic when in permissionless mode. Just to double check: This means that if there's lots of L1 messages then a permissionless batch will need to include all L1 messages first before any other tx created on L2 (via permissionless batch production toolkit)?
| EnforcedBatchParameters memory parameters = enforcedBatchParameters; | ||
| if (!parameters.enforcedModeEnabled) { | ||
| uint256 timestamp = IL1MessageQueue(messageQueue).getFirstUnfinalizedMessageTimestamp(); | ||
| if (timestamp > 0 && timestamp + parameters.maxDelayEnterEnforcedMode < block.timestamp) { |
There was a problem hiding this comment.
What happens if there's no L1 message (eg because no user posted one on L1)? iiuc then permissionless mode will never be activated. we could make the sending of L1 messages a requirement but so far I thought permissionless mode would be either triggered by a L1 message or just no finalization for too long.
There was a problem hiding this comment.
oh, yeah you are correct. forget to add this check.
No description provided.