Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check basefee in Curie #770

Merged
merged 20 commits into from
May 28, 2024
Merged

feat: check basefee in Curie #770

merged 20 commits into from
May 28, 2024

Conversation

0xmountaintop
Copy link
Member

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@0xmountaintop 0xmountaintop force-pushed the new_basefee branch 2 times, most recently from 38b1c9b to 15570ec Compare May 25, 2024 10:32
@0xmountaintop 0xmountaintop changed the title feat: fix basefee check feat: check basefee in Curie May 25, 2024
@0xmountaintop 0xmountaintop marked this pull request as ready for review May 25, 2024 14:33
@0xmountaintop 0xmountaintop force-pushed the new_basefee branch 3 times, most recently from 6cdeb69 to b37d174 Compare May 27, 2024 06:43
@0xmountaintop 0xmountaintop changed the title feat: check basefee in Curie [WIP] feat: check basefee in Curie May 27, 2024
@0xmountaintop 0xmountaintop force-pushed the new_basefee branch 5 times, most recently from 0c2be2c to 13ebc06 Compare May 27, 2024 12:31
@0xmountaintop 0xmountaintop changed the title [WIP] feat: check basefee in Curie feat: check basefee in Curie May 27, 2024
@0xmountaintop 0xmountaintop merged commit e517149 into new May 28, 2024
2 of 3 checks passed
@0xmountaintop 0xmountaintop deleted the new_basefee branch May 28, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant