forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(zktrie): fix deletion proofs and collect them in commiting phase #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmountaintop
changed the title
Fix/deletion proof 2
fix: fix deletion proofs and collect them in commiting phase
Apr 10, 2023
0xmountaintop
previously approved these changes
Apr 10, 2023
0xmountaintop
changed the title
fix: fix deletion proofs and collect them in commiting phase
fix(zktrie): fix deletion proofs and collect them in commiting phase
Apr 10, 2023
Has been tested under some artificial contract |
0xmountaintop
previously approved these changes
Apr 12, 2023
Thegaram
reviewed
Apr 18, 2023
We have run a node with this PR as a patched for a month and it seems to be stable with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the second fixing on deletion proof base on issue #253 and it replace PR#247.
With this PR, we: