address AI's comments: add nil checks

scroll-tech · Oct 21, 2024 · b8de612 · b8de612
1 parent 3284547
commit b8de612
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/rollup/da_syncer/da/commitV1.go b/rollup/da_syncer/da/commitV1.go
@@ -65,6 +65,10 @@ func NewCommitBatchDAWithBlob(ctx context.Context, db ethdb.Database,
 		return nil, fmt.Errorf("failed to decode txs from blob: %w", err)
 	}
 
+	if decodedChunks == nil {
+		return nil, fmt.Errorf("decodedChunks is nil after decoding")
+	}
+
 	v0, err := NewCommitBatchDAV0WithChunks(db, version, batchIndex, parentBatchHeader, decodedChunks, skippedL1MessageBitmap, vLog.BlockNumber)
 	if err != nil {
 		return nil, err

diff --git a/rollup/rollup_sync_service/rollup_sync_service.go b/rollup/rollup_sync_service/rollup_sync_service.go
@@ -305,6 +305,9 @@ func (s *RollupSyncService) parseAndUpdateRollupEventLogs(logs []types.Log, endB
 }
 
 func (s *RollupSyncService) getLocalChunksForBatch(chunkBlockRanges []*rawdb.ChunkBlockRange) ([]*encoding.Chunk, error) {
+	if len(chunkBlockRanges) == 0 {
+		return nil, fmt.Errorf("chunkBlockRanges is empty")
+	}
 	endBlockNumber := chunkBlockRanges[len(chunkBlockRanges)-1].EndBlockNumber
 	for i := 0; i < defaultMaxRetries; i++ {
 		if s.ctx.Err() != nil {