Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #264

Merged
merged 3 commits into from
Feb 1, 2025
Merged

Cleanup #264

merged 3 commits into from
Feb 1, 2025

Conversation

tiennou
Copy link
Contributor

@tiennou tiennou commented Jan 25, 2025

Brief Description

Remove leftovers. See individual commits for details

Checklists

  • Test passed
  • Coding style (indentation, etc)
  • Edits have been made to src/ files not index.d.ts
  • Run npm run compile to update index.d.ts

@tiennou
Replace hard-coded FIND_ values with their constant
408d92b
@tiennou
Remove a couple of leftovers
3c5378c 
- Room.mode doesn't look like it exists anymore
- Remove duplicates from StructureSpawn, they're inherited from Structure
- Remove AllLookAtTypes.exit
- Remove SurvivalGameInfo
@tiennou tiennou mentioned this pull request Jan 25, 2025
Closed
4 tasks
DiamondMofeng
DiamondMofeng approved these changes Feb 1, 2025
View reviewed changes
Copy link
Member

@DiamondMofeng DiamondMofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DiamondMofeng DiamondMofeng merged commit 1f73abf into screepers:master Feb 1, 2025
3 checks passed
@tiennou tiennou deleted the cleanup branch February 2, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiamondMofeng DiamondMofeng DiamondMofeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiennou @DiamondMofeng