Fixes issue #1 #36
Open
Fixes issue #1 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gallaecio
reviewed
Mar 12, 2020
| @@ -31,7 +31,6 @@ def fromstring(cls, price: Optional[str], | |||
| Given price and currency text extracted from HTML elements, return | |||
| ``Price`` instance, which provides a clean currency symbol and | |||
| price amount as a Decimal number. | |||
|
|
|||
There was a problem hiding this comment.
What do you have against paragraphs? 😛
There was a problem hiding this comment.
That might be due to the auto-indentation of Pycharm. We can definitely undo it. 😄
| @@ -201,11 +197,18 @@ def extract_price_text(price: str) -> Optional[str]: | |||
| m = re.search(r""" | |||
| (\d[\d\s.,]*) # number, probably with thousand separators | |||
| \s*? # skip whitespace | |||
| ([m|M,b|B]il\w*)? # check million* or billion* | |||
There was a problem hiding this comment.
Please, check out how [] works.
There was a problem hiding this comment.
Thanks @Gallaecio for flagging this!
I'll update it with: ([mMbB]il\w*)?
Let me know if there's still some improvement that needs to be made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made some edits to the parser.py file to get the issue resolved and let the library detect mill, million, billion etc.