Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect ignored requests on find #501

Closed

Conversation

camallen
Copy link

@camallen camallen commented Jul 5, 2024

ensure we can set a request to be ignored in a background processing system via a before hook and the request manager should return the ignored request instead of creating a new one

related issues #336

ensure we can set a request to be ignored in a background processing system via a before hook and the request manager should return the ignored request instead of creating a new one

related issues scoutapp#336
@lancetarn
Copy link
Contributor

Hello! This seems like the right thing to be doing! Thank you for the time and effort. We are working on managing the dependencies causing these test failures and will get this merged soon.

@camallen camallen marked this pull request as draft July 17, 2024 23:36
@camallen
Copy link
Author

This PR doesn't work as expected and is not currently mergeable.

With this change the RequestManager reuses the ignored tracked request and it never clears after a job is processed. I'm still looking at public APIs or a new reset API to enforce the ignored request clears correctly.

@camallen
Copy link
Author

Closing this PR for now to keep things tidy

@camallen camallen closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants