Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
@jrothrock @natematykiewicz - I missed an edge case in #486
The
replace
action inon_hash
should ideally run only for the case where the Ruby 3.1 hash shorthand syntax is used. If thevalue_node
takes in an argument, we can be sure it's not the shorthand syntax case. This PR adds a check for that:Test
Without the change,
params["timestamp"]
gets dropped:leading to errors like
wrong number of arguments (given 0, expected 1) (ArgumentError)
.