Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for receiving HTML input and bug fix #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

advance512
Copy link

Added support for receiving HTML input
Fixed issue with dimensions(tag) not working for some websites

Fixed issue with dimensions(tag) not working for some websites
Copy link
Owner

@scottwernervt scottwernervt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why the Travis CI is not showing up in gitlab checks but there are some errorshttps://travis-ci.org/github/scottwernervt/favicon/builds/699454421.

The py27 test is failing so I think we might have to move html_override arg in front of *args.

tests/test_favicon.py Outdated Show resolved Hide resolved
tests/test_favicon.py Outdated Show resolved Hide resolved
src/favicon/favicon.py Show resolved Hide resolved
@advance512
Copy link
Author

I am not sure why the Travis CI is not showing up in gitlab checks but there are some errorshttps://travis-ci.org/github/scottwernervt/favicon/builds/699454421.

The py27 test is failing so I think we might have to move html_override arg in front of *args.

Unfortunately we can't do that, as that will mean that code like this:

favicon.get('http://mock.com/', headers)

will see the headers as the html parameter and break. Putting the html parameter after the args* means it becomes a keyword only argument, which solves it.
Alternatively, we can modify the version to show non-comaptibility, or drop Python 2.x support (it is EOL'd after all).

Change: test corrected and minimized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants