Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multiple tips being displayed during sort #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed multiple tips being displayed during sort #43

wants to merge 1 commit into from

Conversation

sfavorite
Copy link

Using selectAll should remove extra tool tips created when a sort is running. I attached a picture of my after a sort.

Screenshot from 2019-12-07 07-49-37

@scotthmurray
Copy link
Owner

Thanks @sfavorite! I have no immediate plans to update the master branch here, unless I were to update the book, to prevent confusion for readers. I'm going to leave this PR open and if and when I do an update, I will be sure to incorporate your contribution (and update the book text accordingly). Thanks!

@sfavorite
Copy link
Author

I completely understand, Mr. Murray. Thank you for the consideration.

I have learned a lot from the book and am using D3 v5 and only a couple of changes have been needed to deal with promises - at least as far as chapter 11. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants