Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buffer overrun in showString() #224

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Fix buffer overrun in showString() #224

merged 2 commits into from
Oct 6, 2024

Conversation

kitlaan
Copy link
Contributor

@kitlaan kitlaan commented Oct 24, 2023

Found a crash by sending a too-long string via MQTT.

I assume the check in showString() was just forgotten, rather than intentional.

kitlaan and others added 2 commits October 23, 2023 23:47
@kitlaan
NUM_MODULES bounds check
aaa8917 
Add a check to showString() to prevent buffer overrun.
@scottbez1
Merge branch 'master' into kitlaan-patch-1
6c39c9a
scottbez1
scottbez1 approved these changes Oct 6, 2024
View reviewed changes
Copy link
Owner

@scottbez1 scottbez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@scottbez1 scottbez1 merged commit 8db0a90 into scottbez1:master Oct 6, 2024
11 checks passed
@kitlaan kitlaan deleted the kitlaan-patch-1 branch October 6, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottbez1 scottbez1 scottbez1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitlaan @scottbez1