Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed object not iterable error #148

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Yash621
Copy link
Contributor

@Yash621 Yash621 commented Mar 23, 2022

While running the app we are getting object not iterable error due to firebase versioning and lack of appId and measurementId in config object as it is necessary to add appId for firebase versions >7.2.0

115932068-d5e64b80-a4a9-11eb-9045-37cf4045cccc

This PR is for fixing that issue.

@Yash621 Yash621 requested a review from shehand as a code owner March 23, 2022 19:07
@Kanha-13
Copy link
Contributor

@Yash621 this one also

@Yash621
Copy link
Contributor Author

Yash621 commented Mar 24, 2022

@Kanha-13 your PR was not solving the issue, as the main issue was in the versioning of firebase and moreover you removed this code block
export const f = firebase; export const database = firebase.database(); export const auth = firebase.auth(); export const storage = firebase.storage(); export const MAP_API = MAP_API_KEY;

which will break the peer dependencies in the whole app and will cause the app to just break down so I just raised a new PR for a more sophisticated and tested fix for the issue.

@Kanha-13
Copy link
Contributor

@Yash621 have you tried ./gradlew clean build , because I resolved this bug with my change and it worked for me

@Yash621
Copy link
Contributor Author

Yash621 commented Mar 24, 2022

@Kanha-13 ya the reason for that is in other files they are importing from config.js and you have removed the peer dependencies in config.example.js due to which the app is not accessing those variables but when the app will be running in production we will be renaming config.exapmle.js to config.js and hence the peer dependencies will break at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants