Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java exception and assets load fix #146

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Kanha-13
Copy link
Contributor

@Kanha-13 Kanha-13 commented Mar 22, 2022

This PR include 5 fixes:

  1. fix for java.lang.ExceptionInInitializerError

    Resources for this fix:

  1. fix for unable to load script from assets Unable to load script from assets 'index.android.bundle'.  #138

    Resources for this fix:

  1. fix for dependency
    Updated package.js as @react-native-community/toolbar-android module is missing in the dependency

  2. fix for missing import of Platform in forumbox/style.js
    modified **style.js **

  • added import platform from react-native
  1. fix for Throw an error "Object is not iterable" at the app start  #128
    modified config.example.js
  • firebase.initializeApp(firebaseConfig); causing error so wrapped that in try-catch
  • modified firebase import

@Kanha-13 Kanha-13 requested a review from shehand as a code owner March 22, 2022 15:28
@Kanha-13 Kanha-13 changed the title This PR includes 2 fix Java exception and assets load fix Mar 22, 2022
@@ -1,19 +1,38 @@
import firebase from "firebase";
import { ALREADY_LAUNCHED } from "@env";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Need

Comment on lines 31 to 38
"https://api.rss2json.com/v1/api.json?rss_url=https://medium.com/feed/scorelab";
export const GITHUB_API =
"https://api.github.com/orgs/scorelab/repos?sort=pushed&per_page=10";

export default {
ALREADY_LAUNCHED,
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need. Update Accordingly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will revert it

@shehand
Copy link
Collaborator

shehand commented Apr 2, 2022

Shall we decouple this PR in a way so that all isssue has a one PR related to it.

@Kanha-13
Copy link
Contributor Author

Kanha-13 commented Apr 2, 2022

Yeah sure I too was looking a way to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants