Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code labz app bar #830

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kushalShukla-web
Copy link
Contributor

@kushalShukla-web kushalShukla-web commented Jul 13, 2023

Description

i changed position inside Route component so that when user is present on Path ="/" only able to see that app bar . instead if he goes on other link , he cant .

Related Issue

  1. first go to home page by running npm run dev
  2. after go to login page and still you can see the searchbar and codelabz icon on top . which is kind of weird

i will create issue regarding this pr

Motivation and Context

How Has This Been Tested?

Screenshots or GIF (In case of UI changes):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

kushalShukla-web and others added 6 commits July 11, 2023 01:15
… previous it wont accept email that having space after .com and yahoo.com
… previous it wont accept email that having space after .com and yahoo.com
…for more info visit Validate mail pull request
…for more info visit Validate mail pull request
…ous one the component can be render on every page like on login page and sign up page .
oops i just hard coded HomePage :/. just removed it .
@kushalShukla-web
Copy link
Contributor Author

solved #831

@kushalShukla-web
Copy link
Contributor Author

@Sarfraz-droid @Maahi10001 guys pls go through my pr .

@Sarfraz-droid
Copy link
Collaborator

@kushalShukla-web Your code has conflicts with forgotpassword.cy.js. Please sync the changes from the master and commit

@Sarfraz-droid
Copy link
Collaborator

Sarfraz-droid commented Jul 14, 2023

@kushalShukla-web There are other routes as well where the appbar is needed. So having the appbar only on / path is not a good option.
However we can come around with a different solution on routes where we don't require appbar

@kushalShukla-web
Copy link
Contributor Author

hey do i need to learn Cypress testing tool ? as i saw sometimes it create problem while creating pr .

@kushalShukla-web
Copy link
Contributor Author

@kushalShukla-web There are other routes as well where the appbar is needed. So having the appbar only on / path is not a good option. However we can come around with a different solution on routes where we don't require appbar

ohkay i got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants