-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code labz app bar #830
base: master
Are you sure you want to change the base?
Code labz app bar #830
Conversation
… previous it wont accept email that having space after .com and yahoo.com
… previous it wont accept email that having space after .com and yahoo.com
…for more info visit Validate mail pull request
…for more info visit Validate mail pull request
…ous one the component can be render on every page like on login page and sign up page .
oops i just hard coded HomePage :/. just removed it .
solved #831 |
@Sarfraz-droid @Maahi10001 guys pls go through my pr . |
@kushalShukla-web Your code has conflicts with |
@kushalShukla-web There are other routes as well where the appbar is needed. So having the appbar only on |
hey do i need to learn Cypress testing tool ? as i saw sometimes it create problem while creating pr . |
ohkay i got it |
Description
i changed position inside Route component so that when user is present on Path ="/" only able to see that app bar . instead if he goes on other link , he cant .
Related Issue
i will create issue regarding this pr
Motivation and Context
How Has This Been Tested?
Screenshots or GIF (In case of UI changes):
Types of changes
Checklist: