Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Fix : Inconsistent step titles (#1025) ] #1028

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rohitPandey469
Copy link

Description

This pull request addresses the issue of inconsistent step titles displayed in Editor Mode by ensuring that the currentStepNo is correctly passed and utilized in the StepsTitle component. Previously, the current_step_no was being accessed from redux store which don't seem to be necessary as doing the same in abpve component.

No visual enhancements have been made in this update.

Related Issue

Fixes #1025

##Video

Codelabz.-.Google.Chrome.2024-01-06.15-13-35.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rohitPandey469
Copy link
Author

Note to Reviewers

In this PR, I focused on solving the current issue. However, I noticed that the useSelector hook from Redux is not utilized, and we are passing data from the parent component. This might be an opportunity to refactor and improve the overall structure for better readability and maintainability.

Proposal:

  1. Clean up unused code.
  2. Refactor to make better use of Redux useSelector hook.
  3. Ensure consistency in data flow and state management.

Before proceeding with these changes, I wanted to get your thoughts. Would you prefer addressing these improvements in a separate PR to maintain the focus on the current issue? Let me know your preference, and I'll be happy to proceed accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Fix : Inconsistent Step Titles Displayed in Editor Mode & Visual Enhancement ]
1 participant