Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase tooling_clang_tidy to develop and updated README #80

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

solomonjoseph
Copy link
Contributor

Description

This PR works on issue #63 by creating a target for clang-tidy checks. A python script is downloaded into the build folder via a Cmake script in clang-tidy.cmake. Parameters for the clang-tidy checks can be specified in the .clang-tidy file (eg. which checks to run, warnings as errors, etc).

closes: N/A


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • [X ] Targeted PR against correct branch (develop)
  • [X ] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • [n/a] Wrote unit tests
  • [X ] Updated relevant documentation in the code
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine! Thanks for the PR

@ValarDragon ValarDragon merged commit 14b5164 into develop Nov 13, 2020
@ValarDragon ValarDragon deleted the clang_tidy branch November 13, 2020 18:02
ValarDragon pushed a commit that referenced this pull request Mar 25, 2021
* Rebase tooling_clang_tidy to develop and updated README

* Updated CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants