fix unit tests

scipp · Nov 21, 2023 · cd8876a · cd8876a
1 parent 7797731
commit cd8876a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/ess/dream/io/geant4.py b/src/ess/dream/io/geant4.py
@@ -67,7 +67,7 @@ def group(key: str, da: sc.DataArray) -> sc.DataArray:
         else:
             elems = elements
         res = da.group(*elems)
-        if 'sector' in elems:
+        if 'sector' not in elems:
             res.bins.coords.pop('sector', None)
         return res
 

diff --git a/tests/dream/io/geant4_test.py b/tests/dream/io/geant4_test.py
@@ -89,6 +89,7 @@ def test_load_geant4_csv_endcap_backward_has_expected_coords(file):
     assert_index_coord(endcap.coords['counter'])
     assert_index_coord(endcap.coords['wire'], values=set(range(1, 17)))
     assert_index_coord(endcap.coords['strip'], values=set(range(1, 17)))
+    assert_index_coord(endcap.coords['sumo'], values=set(range(3, 7)))
     assert 'sector' not in endcap.coords
 
     assert 'sector' not in endcap.bins.coords
@@ -104,6 +105,7 @@ def test_load_geant4_csv_endcap_forward_has_expected_coords(file):
     assert_index_coord(endcap.coords['counter'])
     assert_index_coord(endcap.coords['wire'], values=set(range(1, 17)))
     assert_index_coord(endcap.coords['strip'], values=set(range(1, 17)))
+    assert_index_coord(endcap.coords['sumo'], values=set(range(3, 7)))
     assert 'sector' not in endcap.coords
 
     assert 'sector' not in endcap.bins.coords