-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use maintained gopacket fork #4688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not review all 110 files. I assume that all the changes consist in changing the import path. You need to revert all the platform-specific license changes.
Reviewed 104 of 112 files at r1, 8 of 10 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @romshark)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @romshark)
-- commits
line 8 at r2:
Adding random objection to avoid being the sole approver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 104 of 112 files at r1, 8 of 10 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jiceatscion and @romshark)
Previously, jiceatscion wrote…
Adding random objection to avoid being the sole approver.
Second pair of 👀
dist/test/BUILD.bazel
line 29 at r2 (raw file):
tags = [ "exclusive", # "integration",
This appears to be unexpected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @jiceatscion and @romshark)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jiceatscion and @romshark)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @romshark)
google/gopacket is no longer maintained by Google since August 2020. See issue: google/gopacket#1016. Switch to a new actively maintained fork github.com/gopacket/gopacket.
9adf104
to
a9c0497
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 11 files at r4, all commit messages.
Reviewable status: 111 of 112 files reviewed, all discussions resolved (waiting on @jiceatscion and @romshark)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 11 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @romshark)
google/gopacket is no longer maintained by Google since August 2020.
See issue: google/gopacket#1016.
I propose we switch to the new actively maintained fork: https://github.com/gopacket/gopacket.
The most prominent orgs on GitHub already depending on the new fork appear to be github.com/apache and github.com/usnistgov which gives me confidence.