Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use maintained gopacket fork #4688

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Conversation

romshark
Copy link
Contributor

google/gopacket is no longer maintained by Google since August 2020.
See issue: google/gopacket#1016.
I propose we switch to the new actively maintained fork: https://github.com/gopacket/gopacket.

The most prominent orgs on GitHub already depending on the new fork appear to be github.com/apache and github.com/usnistgov which gives me confidence.

@romshark romshark added the refactor Change that focuses around reducing tech debt label Jan 29, 2025
@romshark romshark self-assigned this Jan 29, 2025
@romshark romshark requested review from a team and jiceatscion as code owners January 29, 2025 10:04
@jiceatscion
Copy link
Contributor

This change is Reviewable

@romshark romshark changed the title refactor: Use maintained gopacket fork refactor: use maintained gopacket fork Jan 29, 2025
Copy link
Contributor

@jiceatscion jiceatscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review all 110 files. I assume that all the changes consist in changing the import path. You need to revert all the platform-specific license changes.

Reviewed 104 of 112 files at r1, 8 of 10 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @romshark)

Copy link
Contributor

@jiceatscion jiceatscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @romshark)


-- commits line 8 at r2:
Adding random objection to avoid being the sole approver.

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 104 of 112 files at r1, 8 of 10 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jiceatscion and @romshark)


-- commits line 8 at r2:

Previously, jiceatscion wrote…

Adding random objection to avoid being the sole approver.

Second pair of 👀


dist/test/BUILD.bazel line 29 at r2 (raw file):

    tags = [
        "exclusive",
        # "integration",

This appears to be unexpected.

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @jiceatscion and @romshark)

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jiceatscion and @romshark)

Copy link
Contributor

@jiceatscion jiceatscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @romshark)

@romshark romshark enabled auto-merge (squash) January 29, 2025 17:57
@romshark romshark disabled auto-merge January 29, 2025 17:57
google/gopacket is no longer maintained by Google since August 2020.
See issue: google/gopacket#1016.
Switch to a new actively maintained fork github.com/gopacket/gopacket.
@romshark romshark force-pushed the use-maintained-gopacket-module branch from 9adf104 to a9c0497 Compare January 29, 2025 18:00
@romshark romshark enabled auto-merge (squash) January 29, 2025 18:15
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 11 files at r4, all commit messages.
Reviewable status: 111 of 112 files reviewed, all discussions resolved (waiting on @jiceatscion and @romshark)

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 11 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @romshark)

@romshark romshark merged commit 6ac5a00 into master Jan 29, 2025
6 checks passed
@romshark romshark deleted the use-maintained-gopacket-module branch January 30, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Change that focuses around reducing tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants