Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes and tests annotating kinds #2

Merged
merged 2 commits into from
Oct 25, 2023
Merged

fixes and tests annotating kinds #2

merged 2 commits into from
Oct 25, 2023

Conversation

timothypratley
Copy link
Contributor

@timothypratley timothypratley commented Oct 25, 2023

The previous implementation was not detecting cases like ^:kind/table {...}
These changes allow pretty much any comprehensible style to be detected,
and additionally disallows arbitrary kinds (all kinds must be keywords in the kind namespace).

@timothypratley timothypratley requested a review from daslu October 25, 2023 05:05
@daslu
Copy link
Member

daslu commented Oct 25, 2023

@timothypratley this looks great, much cleaner and clearer than before.

I'm merging this.

When we meet, let us discuss, as you proposed, whether this is the way that Vars should be handled.
This way we are losing the ability to recognize :kind/var, which is currently handled though a predicate.

By the way, one easier way to handle the function case
https://github.com/scicloj/kindly-advice/pull/2/files#diff-3cb40375660dcdc0cf0e1baae63af6e4ccfc24b246af41dbe1987df5eaa2ae79R25
might be simply using the return value:

(kind/table) ; => :kind/table

@daslu daslu merged commit 855957f into main Oct 25, 2023
1 check passed
daslu added a commit that referenced this pull request Oct 25, 2023
@timothypratley timothypratley deleted the fix-and-test-annotations branch October 25, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants