Add NewPool, fix some typos and add clarification on Bindings not be… #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schwartzmx
force-pushed
the
pool
branch
7 times, most recently
from
dd61838
to
f8a661a
Compare
…ng supported by AWS Neptune
gedge
reviewed
Oct 13, 2019
| @@ -137,7 +137,7 @@ func (c *Client) authenticate(requestID string) (err error) { | |||
| return | |||
| } | |||
|
|
|||
| // ExecuteWithBindings formats a raw Gremlin query, sends it to Gremlin Server, and returns the result. | |||
| // ExecuteWithBindings formats a raw Gremlin query, sends it to Gremlin Server, and returns the result. NOTE: AWS Neptune does not currently support bindings or rebindings see: https://docs.aws.amazon.com/neptune/latest/userguide/access-graph-gremlin-differences.html | |||
| func (c *Client) ExecuteWithBindings(query string, bindings, rebindings map[string]string) (resp []Response, err error) { | |||
There was a problem hiding this comment.
Given the lack of support, perhaps:
return nil, errors.New("Bindings not supported")
or similar
gedge
reviewed
Oct 13, 2019
| @@ -164,7 +164,7 @@ func (c *Client) ExecuteAsync(query string, responseChannel chan AsyncResponse) | |||
| return | |||
| } | |||
|
|
|||
| // ExecuteFileWithBindings takes a file path to a Gremlin script, sends it to Gremlin Server with bindings, and returns the result. | |||
| // ExecuteFileWithBindings takes a file path to a Gremlin script, sends it to Gremlin Server with bindings, and returns the result. NOTE: AWS Neptune does not currently support bindings or rebindings see: https://docs.aws.amazon.com/neptune/latest/userguide/access-graph-gremlin-differences.html | |||
| func (c *Client) ExecuteFileWithBindings(path string, bindings, rebindings map[string]string) (resp []Response, err error) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing supported by AWS Neptune
closes #2
@shutcode is this something along the lines of what you were thinking? Trying to make this extensible if new configuration is added for configuring the Pool. I'm definitely open to refactoring this as I think initializing the Pool and client is a bit clunky and verbose, having to deal with Ws dialers and configs.