-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #1143
base: master
Are you sure you want to change the base?
Spelling #1143
Conversation
I think changing spelling mistakes in licenses is wrong. The commits modify the openssl license. |
I'll drop those later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schwabe are these the only license files that concerned you?
As a sidenote. 85 commits for the spelling is a lot. I will probably squash a few of them together before merging (unless you do it first). Changing the localization keys will invalidate all the localisations in crowdin locatisation service. I am not sure if that is worth fixing the spelling mistakes. Have to think about that. |
I can split that out to a distinct PR or however you request. I leave them as distinct commits while working on them because it makes it easier to drop things as a set (e.g. if i needed to drop the squashing/etc. is totally up to the project, I'm fairly flexible. I won't squash until (a) the build is green and (b) you're happy w/ things -- as it's fairly hard to unsquash, but trivial to squash... |
9b2d4bf
to
53c853e
Compare
ok, this is green. Let me know what you need done, and I can look into doing it (probably Tuesday). |
08e55f3
to
b55f007
Compare
3ac849f
to
e4597ec
Compare
2290b8d
to
f010753
Compare
Generated by https://github.com/jsoref/spelling
f
; to maintain your repo, please considerfchurn
Note: Normally I exclude localizations. The only reason they're included is that I was migrating these changes from ProtonVPN/android-app#8 and hadn't excluded them yet. I'm happy to drop them if requested.
I try to exclude third party content. If I've missed something, please let me know, and if possible direct me to its upstream.