bug: Fix aws_cloudwatch_log_group resource
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resource should only exist if a SNS topic ARN is specified, otherwise `aws_cloudwatch_log_metric_filter.iam_activity` can fail if the log group is not looked up. Signed-off-by: Stephen Hoekstra <[email protected]>
Terraform Format and Style 🖌
|
shoekstra
changed the title
aws_cloudwatch_log_group resourceaws_cloudwatch_log_group resource
Plork
approved these changes
Dec 4, 2023
stefanwb
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resource should only exist if a SNS topic ARN is specified,
otherwise
aws_cloudwatch_log_metric_filter.iam_activitycan fail ifthe log group is not looked up.
Signed-off-by: Stephen Hoekstra [email protected]