Date deserialization format type(s) #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iKsSs
commented
Oct 18, 2024
•
iKsSs
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| Doc updated | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
|
The new version |
scyzoryck
approved these changes
Oct 28, 2024
|
@iKsSs Could you take a look at the failing test, please? |
Use supported step for artifacts upload.
iKsSs
force-pushed
the
date-deserialization
branch
from
ebdf95e to
1b573e5
Compare
ofc, should be fixed.. |
|
OK, I fixed the missing 'use' in the test from the previous commit(s) |
|
Every failed test in PHP7.4 is connected to serialization :( |
|
I will take a look - I think I know where the problem is :) |
Add doctrine/annotations into dev dependencies.
Use new Download coverage class.
scyzoryck
approved these changes
Nov 1, 2024
|
Thanks @iKsSs for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.