[Fix] Changed localeChoosingListener on kernel request #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome page on symfony 3.4.7
|
Thank you @Losams for you work, I hope this can be merged soon. |
|
Thanks @Losams will try to take a look at the issue this weekend. |
|
@acasademont Any updates? :) |
|
hey guys, so sorry for the late review. I'm trying to understand what's the underlying problem here, one test is also failing due to the patch. Could you please elaborate a bit more @Losams? |
|
Yes IDK why the "testNoCookieOnError" crashed, to be honest I didn't check so far. All I can say is what I said on the commit : "On symfony 3.4.7, the welcome page didn't throw an exception anymore (in debug mode)." So the localeChoosingListener didn't fire anymore (only on debug env). For that I changed the dispatch to kernel.request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type : [Fix] Problem with the welcome page on symfony 3.4.7
On symfony 3.4.7, the welcome page didn't throw an exception anymore (in debug mode). The localeChoosingListener has been put in kernel.request instead.