Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony 4.0 patch #309

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Symfony 4.0 patch #309

wants to merge 3 commits into from

Conversation

RickySu
Copy link

@RickySu RickySu commented May 28, 2018

Symfony 4.0 has many breaking changes.

  • The DefinitionDecorator class has been removed. Use the ChildDefinition class instead.
  • Definitions and aliases are now private by default in 4.0. You should either use service injection or explicitly define your services as public if you really need to inject the container.

DependencyInjection

GuilhemN
GuilhemN reviewed May 28, 2018
View reviewed changes
composer.json
"symfony/validator": "~4.0",
"symfony/form": "~4.0",
"symfony/class-loader": "~4.0",
"symfony/yaml": "~4.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite restrictive, we should keep supporting 3.x for now imo. Could you instead use 4.0 classes only if they're available?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can create a new branch for 4.x, and mark release version as 2.0.x.
Supporting 3.x and 4.x both needs some workarounds.

@phansys phansys mentioned this pull request Jul 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuilhemN GuilhemN GuilhemN left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RickySu @GuilhemN