Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for using SDK as ESM #256

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Fix for using SDK as ESM #256

merged 4 commits into from
Oct 11, 2023

Conversation

joawan
Copy link
Member

@joawan joawan commented Oct 10, 2023

Importing the SDK as real ESM does not work due to

  1. Missing file extension
  2. Importing json

@joawan joawan requested a review from a team October 10, 2023 18:36
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #256 (7289e12) into master (6cc771b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7289e12 differs from pull request most recent head f626fec. Consider uploading reports for the commit f626fec to get more accurate results

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   99.78%   99.79%           
=======================================
  Files          13       13           
  Lines         476      478    +2     
  Branches       96       96           
=======================================
+ Hits          475      477    +2     
  Misses          1        1           
Files Coverage Δ
src/RESTClient.js 100.00% <ø> (ø)
src/cache.js 100.00% <ø> (ø)
src/identity.js 99.52% <100.00%> (+<0.01%) ⬆️
src/monetization.js 100.00% <100.00%> (ø)
src/object.js 100.00% <ø> (ø)
src/payment.js 100.00% <ø> (ø)
src/popup.js 100.00% <ø> (ø)
src/spidTalk.js 100.00% <ø> (ø)
src/url.js 100.00% <ø> (ø)
src/validate.js 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joawan joawan merged commit 6ff49b9 into master Oct 11, 2023
6 checks passed
@joawan joawan deleted the esm-js branch October 11, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants