Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed everything to esm and updated to pkg.json to module #251

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Conversation

joawan
Copy link
Member

@joawan joawan commented Oct 6, 2023

Tested with https://github.com/schibsted/sdk-example

  • Go to this branch, run npm link
  • Download sdk example, run npm link @schibsted/account-sdk-browser
  • Create the .env file in sdk-example (add a bogus client_id, client_secret and sessionDomain)
  • Run npm run dev in sdk-example
  • See how build works and the localhost:9000

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #251 (55604c6) into master (3b14a28) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 55604c6 differs from pull request most recent head 3a3a4d5. Consider uploading reports for the commit 3a3a4d5 to get more accurate results

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
- Coverage   99.79%   99.78%   -0.01%     
==========================================
  Files          13       13              
  Lines         478      476       -2     
  Branches       96       96              
==========================================
- Hits          477      475       -2     
  Misses          1        1              
Files Coverage Δ
src/identity.js 99.51% <ø> (-0.01%) ⬇️
src/monetization.js 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wojtekk wojtekk requested a review from a team October 6, 2023 09:10
Copy link
Contributor

@ole-martin ole-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, should be backwards compatible, altho it's hard to say 100% sure. Minor version bump would probably be OK.

Copy link
Collaborator

@bogdan-niculescu-sch bogdan-niculescu-sch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joawan joawan merged commit 2680e35 into master Oct 9, 2023
6 checks passed
@joawan joawan deleted the esm branch October 9, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants