Fix for integer overflow bug in binary search. #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performing arithmetic on 2 keys can lead to signed integer overflow/underflow in the binary search algorithm. The result can lead to keys not being found or being inserted in the wrong place. This bug was caught using UBSAN.
The masking of most significant bit in key generation routines should also be reconsidered:
lbtree/keygen-8B/keygen.c
Line 28 in 92f7304
lbtree/common/keyinput.h
Line 191 in 92f7304