Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for integer overflow bug in binary search. #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpsi
Copy link

@dpsi dpsi commented Mar 23, 2021

Performing arithmetic on 2 keys can lead to signed integer overflow/underflow in the binary search algorithm. The result can lead to keys not being found or being inserted in the wrong place. This bug was caught using UBSAN.

The masking of most significant bit in key generation routines should also be reconsidered:

return (((a<<32)^(b<<16)^(c)) & (0x7FFFFFFFFFFFFFFFLL));

return (((a<<32)^(b<<16)^(c)) & (0x7FFFFFFFFFFFFFFFLL));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant