fix(textinput): onKeyUp/Down not forwarded #4385
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentaudebert
requested review from
johnrazeur,
matthprost and
lisalupi
as code owners
🦋 Changeset detectedLatest commit: 696d17f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
radhi-nasser-scaleway
approved these changes
Oct 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4385 +/- ##
=======================================
Coverage 86.76% 86.76%
=======================================
Files 318 318
Lines 11640 11640
Branches 3231 3230 -1
=======================================
Hits 10100 10100
Misses 1540 1540
Continue to review full report in Codecov by Sentry.
|
fabienhebert
approved these changes
Oct 23, 2024
matthprost
approved these changes
Oct 24, 2024
matthprost
requested changes
Oct 24, 2024
| "@ultraviolet/ui": patch | ||
| --- | ||
|
|
||
| fix(textinput): onKeyUp/Down not forwarded |
There was a problem hiding this comment.
Suggested change
| fix(textinput): onKeyUp/Down not forwarded | |
| Fix <TextInputV2 /> onKeyUp/Down not forwarded |
lisalupi
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
forward onKeyUp/onKeyDown to TextInput
The following changes where made:
(Describe what you did)
Relevant logs and/or screenshots