-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(textinput): onKeyUp/Down not forwarded #4385
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 696d17f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4385 +/- ##
=======================================
Coverage 86.76% 86.76%
=======================================
Files 318 318
Lines 11640 11640
Branches 3231 3230 -1
=======================================
Hits 10100 10100
Misses 1540 1540
Continue to review full report in Codecov by Sentry.
|
"@ultraviolet/ui": patch | ||
--- | ||
|
||
fix(textinput): onKeyUp/Down not forwarded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix(textinput): onKeyUp/Down not forwarded | |
Fix <TextInputV2 /> onKeyUp/Down not forwarded |
Summary
Type
Summarise concisely:
What is expected?
forward onKeyUp/onKeyDown to TextInput
The following changes where made:
(Describe what you did)
Relevant logs and/or screenshots