Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SelectInputV2): various improvements #4339

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

<SelectInputV2 />:

  • Hide search when less than 6 items (even when searchable = true)
  • Clickable footer to close the dropdown
  • clearable = false by default now
  • Dropdown will close when clicking outside when it is inside a modal

The following changes were made:

  1. Changed default value of prop clearable
  2. Changed type of prop footer
  3. Manage case selectInput in a modal
  4. Updated stories
  5. Added test for footer

@lisalupi lisalupi added the enhancement New feature or request label Oct 10, 2024
@lisalupi lisalupi requested review from matthprost and a team October 10, 2024 15:26
@lisalupi lisalupi self-assigned this Oct 10, 2024
@lisalupi lisalupi requested review from Lawndlwd and removed request for a team October 10, 2024 15:26
Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: e83de16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 27.65957% with 34 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@357c617). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...kages/ui/src/components/SelectInputV2/Dropdown.tsx 41.37% 17 Missing ⚠️
.../components/SelectInputV2/__tests__/index.test.tsx 5.88% 16 Missing ⚠️
packages/ui/src/components/SelectInputV2/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4339   +/-   ##
=======================================
  Coverage        ?   86.61%           
=======================================
  Files           ?      316           
  Lines           ?    11599           
  Branches        ?     3209           
=======================================
  Hits            ?    10047           
  Misses          ?     1552           
  Partials        ?        0           
Files with missing lines Coverage Δ
packages/ui/src/components/SelectInputV2/index.tsx 57.50% <0.00%> (ø)
.../components/SelectInputV2/__tests__/index.test.tsx 10.76% <5.88%> (ø)
...kages/ui/src/components/SelectInputV2/Dropdown.tsx 42.81% <41.37%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 357c617...26778e0. Read the comment docs.

Copy link
Collaborator

@alexandre-combemorel alexandre-combemorel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments to add, I'm not super legit to approve but here is mine

Copy link
Collaborator

@matthprost matthprost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe wait for me to come back from vacation to merge this one as there will be nobody to fix in case of issue 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants