Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add annotation to set health check send proxy protocol #168

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

erebe
Copy link
Contributor

@erebe erebe commented Jul 8, 2024

Hello,

This PR is adding support to set if the health checks are sending proxy protocol before the actual check.
For now, there is no way to control it from Kubernetes.

See support ticket https://console.scaleway.com/support/tickets/1423150 for more information.

docs/loadbalancer-annotations.md Outdated Show resolved Hide resolved
scaleway/loadbalancers_annotations.go Outdated Show resolved Hide resolved
@erebe
Copy link
Contributor Author

erebe commented Aug 26, 2024

Thanks, updated :)

@Nox-404 Nox-404 changed the title Add annotation to set health check send proxy protocol feat: add annotation to set health check send proxy protocol Aug 27, 2024
Copy link
Contributor

@Nox-404 Nox-404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution !

@Nox-404 Nox-404 merged commit 43e1f57 into scaleway:master Aug 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants