Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instance): server create with custom iops volumes #4140

Merged
merged 4 commits into from
Oct 1, 2024
Merged

feat(instance): server create with custom iops volumes #4140

merged 4 commits into from
Oct 1, 2024

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Sep 20, 2024 •
edited
Loading

No description provided.

@Codelax Codelax added the instance Instance issues, bugs and feature requests label Sep 20, 2024
@Codelax
refactor(instance): server create volumes handling
066d6ee 
Code was moved but not improved as the goal was not to break cassettes.
@Codelax Codelax force-pushed the refactor/instance-server-create-volumes branch from 12f5106 to 066d6ee Compare September 20, 2024 15:53
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.79470% with 29 lines in your changes missing coverage. Please review.

Project coverage is 72.50%. Comparing base (5bf53e0) to head (1df954f).
Report is 274 commits behind head on master.

Files with missing lines Patch % Lines
...spaces/instance/v1/custom_server_create_builder.go 81.63% 16 Missing and 11 partials ⚠️
...nal/namespaces/instance/v1/custom_server_create.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4140      +/-   ##
==========================================
- Coverage   75.45%   72.50%   -2.96%     
==========================================
  Files         202      289      +87     
  Lines       44323    54228    +9905     
==========================================
+ Hits        33444    39316    +5872     
- Misses       9653    13298    +3645     
- Partials     1226     1614     +388

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax marked this pull request as draft September 23, 2024 08:19
@Codelax Codelax changed the title refactor(instance): server create volumes handling feat(instance): server create with custom iops volumes Sep 23, 2024
@Codelax Codelax marked this pull request as ready for review September 27, 2024 07:10
@Codelax Codelax marked this pull request as draft September 27, 2024 07:23
@Codelax Codelax marked this pull request as ready for review September 27, 2024 13:35
remyleone
remyleone reviewed Oct 1, 2024
View reviewed changes
internal/namespaces/instance/v1/custom_server_create_builder.go
vb.VolumeType = instance.VolumeVolumeTypeLSSD
case "b", "block":
vb.VolumeType = instance.VolumeVolumeTypeBSSD
case "s", "scratch":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scratch is missing from the examples

@remyleone remyleone added this pull request to the merge queue Oct 1, 2024
Merged via the queue into scaleway:master with commit 3a9d72b Oct 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees
No one assigned
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Codelax @codecov-commenter @remyleone