fix(instance): remove hardcoded offers #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codelax
force-pushed
the
fix/instance-create-remove-default-type
branch
from
0dec6a1
to
570a716
Compare
Codelax
changed the title
remyleone
added
the
priority:lowest
Codelax
force-pushed
the
fix/instance-create-remove-default-type
branch
from
a1598f6
to
d2d7df0
Compare
github-actions
bot
added
load-balancer
Codelax
commented
Oct 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2785 +/- ##
==========================================
- Coverage 75.45% 70.89% -4.56%
==========================================
Files 202 294 +92
Lines 44323 65582 +21259
==========================================
+ Hits 33444 46496 +13052
- Misses 9653 17454 +7801
- Partials 1226 1632 +406 ☔ View full report in Codecov by Sentry. |
Codelax
force-pushed
the
fix/instance-create-remove-default-type
branch
from
2d739a3
to
da9d862
Compare
Codelax
force-pushed
the
fix/instance-create-remove-default-type
branch
from
da9d862
to
6bc0245
Compare
github-actions
bot
added
the
vpc
remyleone
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEV1-S is not available in certain AZ, we remove the default type instead of changing every time Scaleway change its hardware