Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add composition related handlers and field #839

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Add composition related handlers and field #839

merged 4 commits into from
Mar 20, 2024

Conversation

nineclue
Copy link
Contributor

@nineclue nineclue commented Mar 12, 2024 •
edited
Loading

Keyboard Event is missing isComposing field.
HTMLElment is missing composition related event handlers.

Both are listed in MDN documents.

This is my first pull request. Hope it works out.

@nineclue nineclue marked this pull request as draft March 20, 2024 04:50
@nineclue nineclue marked this pull request as ready for review March 20, 2024 05:14
armanbilge
armanbilge approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@armanbilge armanbilge merged commit 02611c2 into scala-js:main Mar 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nineclue @armanbilge