Fetch request body as ReadableStream

[ptrdom]

References #622.

[ptrdom]

I was unable to run sbt prePR, received this error:

[error] /scala-js-dom/readme/Index.scalatex:43:6: type mismatch;
[error]  found   : scalatex.site.Section.Proxy
[error]  required: scalatags.Text.all.Frag
[error]     (which expands to)  scalatags.generic.Frag[scalatags.text.Builder,String]
[error] @sect{scala-js-dom}
[error]      ^
[error] one error found
[error] (readme / Compile / compileIncremental) Compilation failed

It could be an issue with my environment - I am running Windows. WSL returned same errors.

[armanbilge]

Hmm, looks like a problem with the README documentation, I wonder if any of the code you changed touched that somehow. Let me try it as well.

[armanbilge]

Ah, of course. The docs use Fetch which you just changed here right?
https://scala-js.github.io/scala-js-dom/#dom.Fetch

[armanbilge]

You may want to check the code in here, see if there's something you need to update:
https://github.com/scala-js/scala-js-dom/blob/master/example/src/main/scala/example/Example.scala

[ptrdom]

Yes, there is a change to BodyInit type - new member added to the union. Code of the example does not interact with the request body directly, not sure what should be changed there.

[ptrdom]

CI does show some actual Firefox and Scala 3 errors, those I obviously can fix.

[armanbilge]

Does prePR fail for you before you make any changes? E.g. if you just run it on master.

[ptrdom]

Yes 😞

[armanbilge]

Huh, with that same error message? Now that's definitely strange :)

[ptrdom]

I think the only issue left now is the very first one - #628 (comment).

[ptrdom]

And it was a Windows related issue. Big thanks to Microsoft for WSL 👏

[armanbilge]

Nice work getting it green! 🎉

[armanbilge]

This is a very complex API, so thank you for all your efforts and apologies if I'm confused about something in the comments!

[ptrdom]

@armanbilge Thank you for the review! I think I have addressed all of your comments.

[armanbilge]

Sorry, just a few more things I noticed on this pass!

Let's get another pair of eyes, whenever you have a chance @sjrd or @japgolly, much appreciated! :)

[armanbilge]

This looks great, thanks for all your efforts! Just one last tiny thing 😅

[armanbilge]

@ptrdom thanks again for this fantastic contribution! It is now published as 2.0.0+25-ed28f246-SNAPSHOT.

[julienrf]

Hello! Do you plan to cut a release with these changes soon?

[armanbilge]

@julienrf hello :) Out of curiosity, is this blocking something? Although the API facaded here is described in the spec, it's basically unsupported in browsers at this time.
https://caniuse.com/mdn-api_request_request_readablestream_request_body

Otherwise, personally I'm 👍 to a release :) Since we've added new APIs, the next release will be 2.1.0 in which we also need to fix #624. So it will take a little time to get it ready.

[julienrf]

It is not just about the change to the Fetch facade, the PR contains other changes related to the ReadableStream API. As far as I understand, those changes are currently supported by the browsers: https://caniuse.com/?search=readablestream

This is not really blocking us since we can always define the facade we want outside of scala-js-dom, but it would be simpler to just use the one of scala-js-dom. Our related PR is endpoints4s/endpoints4s#972

[armanbilge]

Ah, that's right, you want to use this as your stream implementation :) thanks for the reply. I'll start getting a release together.

[armanbilge]

@julienrf I just released v2.1.0. @ptrdom thank you again for this fantastic contribution, also looks like you've been doing great work in endpoints4s :)

[julienrf]

Thank you!