Recipe for reading uint from contract
#48
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Thank you @technophile-04!! This is a very nice addition.
Made a few minor changes to some of the wording - a few nit picks. I tried to make some of the sentences simpler to understand and maybe ended up over-explaining :D
Overall, it looks good to me and if there are any comments that you don't like; please feel free to disregard and lmk if you have any question to me.
Thank you once again & Happy new year! :)
Co-authored-by: Eda Akturk <[email protected]>
Co-authored-by: Eda Akturk <[email protected]>
Co-authored-by: Eda Akturk <[email protected]>
Co-authored-by: Eda Akturk <[email protected]>
Co-authored-by: Eda Akturk <[email protected]>
|
Tysm Eda and Happy New Year 🚀 !! Love all the suggestions! and updated them 🙌 |
There was a problem hiding this comment.
Great job @technophile-04, and nice wording improves @edakturk14!! 🙌 Love to see more additions to Recipes.
Looks good to me, added a couple of nitpicks and a copy&paste problem in an internal URL.
docs/recipes/ReadUintFromContract.md
Outdated
| description: Learn how to read from contract functions which accepts arguments / no arguments and display them on UI. | ||
| --- | ||
|
|
||
| This recipe demonstrates how to read data from contract functions that accept some arguments (parameters) or no arguments at all and displays it on the UI. |
There was a problem hiding this comment.
Sometimes when I read this sentence it looks strange, maybe because it's too large? (Other times I read it and seems OK heh).
What about: "This recipe demonstrates how to read data from contract functions and display it on the UI. We'll showcase an example that accepts some arguments (parameters), and another with or no arguments at all"
@edakturk14 could you also take a look with your writer's eyes? 🙃
There was a problem hiding this comment.
I like this suggestion much much better, thank you @Pabl0cks. It's much more clear + readable :D
There was a problem hiding this comment.
It's much more clear + readable :D
💯💯, Tysm Pablo 🙌
Co-authored-by: Pablo Alayeto <[email protected]>
Co-authored-by: Pablo Alayeto <[email protected]>
|
Tysm Pablo 🙌 Great suggestions updated them all! |
|
lgtm 🚀 ty both!!! |
|
Thanks all !!, Merging this 🙌 |
Description :
Tackles 2nd point from #25 (comment) also closes #25
Lol not sure if I over-explained it, also please free to suggest better phrasing/wording or pick something that feels too long 🙌